Credential Page Sizings #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manjotsidhu flutter test --coverage is failing due to the use of MediaQuery as it could not find generic widgets. |
|
Upon changing tests, still, the error was persistent, so I changed the height of the container and let the height of the image remain 300. With this, the issue is resolved, and no CI tests fail. |
Pull Request Test Coverage Report for Build 1644137692
💛 - Coveralls |
manjotsidhu
requested changes
Dec 31, 2021
|
@manjotsidhu Required changes done. You may merge it now! |
|
Please don't mix other issues in a single PR. There is no limit to the number of PRs you can submit. |
Ok, sure, let me clean this mess up! Sorry for the inconvenience! |
ItsAdityaKSingh
force-pushed
the
cred_page
branch
from
fd9a6d8
to
0e110c2
Compare
manjotsidhu
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #186
Describe the changes you have made in this PR - Improved sizing of widgets to fit all on the same working screen. Also included sizer package for any future reference.
Screenshots of the changes (If any) -
Checked on different screen sizes!
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.